Messages in this thread | | | Date | Tue, 1 Apr 2014 16:44:47 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 7/7] uprobes/x86: Introduce uprobe_xol_ops and arch_uprobe->ops |
| |
On 04/01, Masami Hiramatsu wrote: > > (2014/04/01 4:44), Oleg Nesterov wrote: > > + > > +static struct uprobe_xol_ops defaule_xop_ops = { > > + .pre_xol = default_pre_xol_op, > > + .post_xol = default_post_xol_op, > > If there is no ops->emulate, I think it should not be defined now. > You can add it when you really need it. :)
Yes, but the next patch will need it. I do not really mind, but if you do not object I'd prefer to define it in this patch (note that it also changes skip_sstep() to check ops->emulate even if it has no users yet). This way the next change will be a little bit simpler.
In the longer term we will (probably) need ops->abort as well, but currently we can assume handle_riprel_post_xol() in arch_uprobe_abort_xol() can do nothing wrong even if ->ops != &defaule_xol_ops (one of the reasons for 3/7).
Oleg.
| |