lkml.org 
[lkml]   [2014]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 5/5] drivers: bus: omap_l3: Change pr_crit() to dev_err() when IRQ request fails
    Date
    Use dev_err() which will going to print the driver's name as well and the
    KERN_ERR level is sufficient in this case (we also print via dev_err when
    there is an error with the mem resources)

    Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
    Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
    Acked-by: Tony Lindgren <tony@atomide.com>
    ---
    drivers/bus/omap_l3_noc.c | 7 +++----
    1 file changed, 3 insertions(+), 4 deletions(-)

    diff --git a/drivers/bus/omap_l3_noc.c b/drivers/bus/omap_l3_noc.c
    index 0eff48585ae3..972691a668a3 100644
    --- a/drivers/bus/omap_l3_noc.c
    +++ b/drivers/bus/omap_l3_noc.c
    @@ -158,8 +158,8 @@ static int omap4_l3_probe(struct platform_device *pdev)
    ret = devm_request_irq(&pdev->dev, l3->debug_irq, l3_interrupt_handler,
    IRQF_DISABLED, "l3-dbg-irq", l3);
    if (ret) {
    - pr_crit("L3: request_irq failed to register for 0x%x\n",
    - l3->debug_irq);
    + dev_err(&pdev->dev, "request_irq failed for %d\n",
    + l3->debug_irq);
    return ret;
    }

    @@ -167,8 +167,7 @@ static int omap4_l3_probe(struct platform_device *pdev)
    ret = devm_request_irq(&pdev->dev, l3->app_irq, l3_interrupt_handler,
    IRQF_DISABLED, "l3-app-irq", l3);
    if (ret)
    - pr_crit("L3: request_irq failed to register for 0x%x\n",
    - l3->app_irq);
    + dev_err(&pdev->dev, "request_irq failed for %d\n", l3->app_irq);

    return ret;
    }
    --
    1.9.1


    \
     
     \ /
      Last update: 2014-04-01 17:21    [W:3.175 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site