Messages in this thread | | | Date | Tue, 1 Apr 2014 12:56:59 +0100 | From | Mark Brown <> | Subject | Re: [PATCH bisect 1/2] ASoC: fsl_sai: Fix buggy configurations in trigger() |
| |
On Tue, Apr 01, 2014 at 11:17:06AM +0800, Nicolin Chen wrote: > The current trigger() has two crucial problems: > 1) The DMA request enabling operations (FSL_SAI_CSR_FRDE) for Tx and Rx are > now totally exclusive: It would fail to run simultaneous Tx-Rx cases. > 2) The TERE disabling operation depends on an incorrect condition -- active > reference count that only gets increased in snd_pcm_open() and decreased > in snd_pcm_close(): The TERE would never get cleared.
Applied, thanks. [unhandled content-type:application/pgp-signature] | |