Messages in this thread | | | Date | Sun, 9 Mar 2014 10:16:32 -0700 | Subject | Re: [PATCH v4] mm: per-thread vma caching | From | Linus Torvalds <> |
| |
On Sun, Mar 9, 2014 at 10:09 AM, Oleg Nesterov <oleg@redhat.com> wrote: > > But it's not the "while we're setting up a new thread", it is "since > vmacache_valid() was called list time". And the cloning task can just > sleep(A_LOT) and then do CLONE_VM. > > Of course, of course, this race is pute theoretical anyway. But imho > makes sense to fix anyway, and the natural/trivial approach is just to > move vmacache_flush(tsk) from dup_mm() to copy_mm(), right after the > "if (!oldmm)" check.
Fair enough, you've convinced me it's subtle enough that we do not want to play games..
Linus
| |