lkml.org 
[lkml]   [2014]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4] mm: per-thread vma caching
From
On Sun, Mar 9, 2014 at 10:09 AM, Oleg Nesterov <oleg@redhat.com> wrote:
>
> But it's not the "while we're setting up a new thread", it is "since
> vmacache_valid() was called list time". And the cloning task can just
> sleep(A_LOT) and then do CLONE_VM.
>
> Of course, of course, this race is pute theoretical anyway. But imho
> makes sense to fix anyway, and the natural/trivial approach is just to
> move vmacache_flush(tsk) from dup_mm() to copy_mm(), right after the
> "if (!oldmm)" check.

Fair enough, you've convinced me it's subtle enough that we do not
want to play games..

Linus


\
 
 \ /
  Last update: 2014-03-09 18:41    [W:0.101 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site