lkml.org 
[lkml]   [2014]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.4 77/99] sunrpc: clarify comments on rpc_make_runnable
    Date
    3.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jeff Layton <jlayton@redhat.com>

    commit 506026c3ec270e18402f0c9d33fee37482c23861 upstream.

    rpc_make_runnable is not generally called with the queue lock held, unless
    it's waking up a task that has been sitting on a waitqueue. This is safe
    when the task has not entered the FSM yet, but the comments don't really
    spell this out.

    Signed-off-by: Jeff Layton <jlayton@redhat.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    Cc: Weng Meiling <wengmeiling.weng@huawei.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    net/sunrpc/sched.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    --- a/net/sunrpc/sched.c
    +++ b/net/sunrpc/sched.c
    @@ -302,8 +302,9 @@ EXPORT_SYMBOL_GPL(__rpc_wait_for_complet
    /*
    * Make an RPC task runnable.
    *
    - * Note: If the task is ASYNC, this must be called with
    - * the spinlock held to protect the wait queue operation.
    + * Note: If the task is ASYNC, and is being made runnable after sitting on an
    + * rpc_wait_queue, this must be called with the queue spinlock held to protect
    + * the wait queue operation.
    */
    static void rpc_make_runnable(struct rpc_task *task)
    {



    \
     
     \ /
      Last update: 2014-03-09 16:43    [W:4.145 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site