lkml.org 
[lkml]   [2014]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [GIT PULL] x86 fixes for v3.14-rc6
From
Date
And yes, of course the change from hardcoded 2 to X86_TRAP_NMI was an afterthought.

On March 7, 2014 7:03:09 PM PST, Linus Torvalds <torvalds@linux-foundation.org> wrote:
>Oww, oww, oww.
>
>DAMMIT.
>
>On Fri, Mar 7, 2014 at 3:25 PM, H. Peter Anvin <hpa@linux.intel.com>
>wrote:
>>
>> A small collection of minor fixes. The FPU stuff is still pending, I
>> fear. I haven't heard anything from Suresh so I suspect I'm going to
>> have to dig into the init specifics myself and fix up the patchset.
>
>I pulled this and then pushed out without test-compiling, because I'm
>not used to the x86 trees causing problems. Usually they've gone
>through a lot of build tests etc.
>
>But dammit, it's broken:
>
> arch/x86/kernel/head_64.o: In function `early_idt_handler':
> (.init.text+0x124): undefined reference to `X86_TRAP_NMI'
>
>because X86_TRAP_NMI is an enum, not a #define.
>
>This can not have worked in your tree either, because that thing has
>never been anything *but* an enum. So I'm pissed off. This patch was
>clearly never tested anywhere. Why was it sent to me?
>
>Grr. Consider yourself cursed at. Saatana.
>
> Linus

--
Sent from my mobile phone. Please pardon brevity and lack of formatting.


\
 
 \ /
  Last update: 2014-03-08 05:21    [W:0.050 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site