Messages in this thread | | | Subject | Re: [GIT PULL] x86 fixes for v3.14-rc6 | From | "H. Peter Anvin" <> | Date | Fri, 07 Mar 2014 19:36:57 -0800 |
| |
And yes, of course the change from hardcoded 2 to X86_TRAP_NMI was an afterthought.
On March 7, 2014 7:03:09 PM PST, Linus Torvalds <torvalds@linux-foundation.org> wrote: >Oww, oww, oww. > >DAMMIT. > >On Fri, Mar 7, 2014 at 3:25 PM, H. Peter Anvin <hpa@linux.intel.com> >wrote: >> >> A small collection of minor fixes. The FPU stuff is still pending, I >> fear. I haven't heard anything from Suresh so I suspect I'm going to >> have to dig into the init specifics myself and fix up the patchset. > >I pulled this and then pushed out without test-compiling, because I'm >not used to the x86 trees causing problems. Usually they've gone >through a lot of build tests etc. > >But dammit, it's broken: > > arch/x86/kernel/head_64.o: In function `early_idt_handler': > (.init.text+0x124): undefined reference to `X86_TRAP_NMI' > >because X86_TRAP_NMI is an enum, not a #define. > >This can not have worked in your tree either, because that thing has >never been anything *but* an enum. So I'm pissed off. This patch was >clearly never tested anywhere. Why was it sent to me? > >Grr. Consider yourself cursed at. Saatana. > > Linus
-- Sent from my mobile phone. Please pardon brevity and lack of formatting.
| |