Messages in this thread Patch in this message | | | From | behanw@converse ... | Subject | [PATCH] module: LLVMLinux: Remove unused function warning from __param_check macro | Date | Fri, 7 Mar 2014 11:08:47 -0800 |
| |
From: Mark Charlebois <charlebm@gmail.com>
This code makes a compile time type check that is optimized away. Clang complains that it generates an unused function.
I believe GCC won't complain for a static inline fuction but would if it was just a static function.
Adding the unused attribute to the function declaration removes the warning.
This code works for both gcc and clang.
Signed-off-by: Mark Charlebois <charlebm@gmail.com> Signed-off-by: Behan Webster <behanw@converseincode.com> --- include/linux/moduleparam.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h index c3eb102..5ce1f67 100644 --- a/include/linux/moduleparam.h +++ b/include/linux/moduleparam.h @@ -346,6 +346,7 @@ static inline void destroy_params(const struct kernel_param *params, /* The macros to do compile-time type checking stolen from Jakub Jelinek, who IIRC came up with this idea for the 2.4 module init code. */ #define __param_check(name, p, type) \ + static inline type *__check_##name(void) __attribute__ ((unused)); \ static inline type *__check_##name(void) { return(p); } extern struct kernel_param_ops param_ops_byte; -- 1.8.3.2
| |