Messages in this thread Patch in this message | | | From | Florian Vaussard <> | Subject | [PATCH v3 2/4] checkpatch: fix spurious vendor compatible warnings | Date | Fri, 7 Mar 2014 14:26:09 +0100 |
| |
With a compatible string like
compatible = "foo";
checkpatch will currently try to find "foo" in vendor-prefixes.txt, which is wrong since the vendor prefix is empty in this specific case.
Skip the vendor test if the compatible is not like
compatible = "vendor,something";
Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch> [joe@perches.com: cleaned the implementation] Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index e304e77..96f10ba 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2055,10 +2055,10 @@ sub process { "DT compatible string \"$compat\" appears un-documented -- check $dt_path\n" . $herecurr); } - my $vendor = $compat; my $vendor_path = $dt_path . "vendor-prefixes.txt"; next if (! -f $vendor_path); - $vendor =~ s/^([a-zA-Z0-9\-]+)\,.*/$1/; + next if $compat !~ /^([a-zA-Z0-9\-]+)\,/; + my $vendor = $1; `grep -Eq "$vendor" $vendor_path`; if ( $? >> 8 ) { WARN("UNDOCUMENTED_DT_STRING", -- 1.8.5.3
| |