lkml.org 
[lkml]   [2014]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tools/net/Makefile: Define PACKAGE to fix bfd build problems
On 03/06/2014 05:54 PM, David Miller wrote:
> From: Markos Chandras <markos.chandras@imgtec.com>
> Date: Thu, 6 Mar 2014 09:15:54 +0000
>
>> Fixes the following build problem with binutils-2.24
>>
>> gcc -Wall -O2 -c -o bpf_jit_disasm.o bpf_jit_disasm.c
>> In file included from bpf_jit_disasm.c:25:0:
>> /usr/include/bfd.h:35:2: error: #error config.h must be included
>> before this header
>> #error config.h must be included before this header
>>
>> This is similar to commit 3ce711a6abc27abce1554e1d671a8762b7187690
>> "perf tools: bfd.h/libbfd detection fails with recent binutils"
>>
>> See: https://sourceware.org/bugzilla/show_bug.cgi?id=14243
>>
>> CC: David S. Miller <davem@davemloft.net>
>> CC: Daniel Borkmann <dborkman@redhat.com>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>
> I think your subject needs to be adjusted, this patch doesn't fix a "bfd"
> build problem.
>
Hi David,

Thanks for the comment. Well it's problem caused by the bfd header.
However, I suppose you can remove the 'bfd' word from the subject as I
understand it's confusing. Would you be able to fix this before you
apply this patch or should I send a new patch?

--
markos


\
 
 \ /
  Last update: 2014-03-07 11:01    [W:0.765 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site