lkml.org 
[lkml]   [2014]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: build failure after merge of the wireless-next tree
On 03/06/2014 03:43 AM, Stephen Rothwell wrote:
> Hi John,
>
> After merging the wireless-next tree, today's linux-next build
> (arm multi_v7_defconfig) failed like this:
>
> drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c: In function
> 'brcmf_sdio_intr_rstatus':
> drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:2464:3: error:
> implicit declaration of function 'atomic_set_mask'
> [-Werror=implicit-function-declaration]
>
> Caused by commit c98db0bec72a ("brcmfmac: Use atomic functions for
> intstatus update"). Arm does not seem to provide
> atomic_set_mask()?
>
> I reverted that commit for today.

That is fine. The kbuild robot also found issue with this function on
other archs. I must say I am surprised as this code fragment in
asm-generic/atomic.h suggests it is needed for SMP to work (?):

20 #ifdef CONFIG_SMP
21 /* Force people to define core atomics */
22 # if !defined(atomic_add_return) || !defined(atomic_sub_return) || \
23 !defined(atomic_clear_mask) || !defined(atomic_set_mask)
24 # error "SMP requires a little arch-specific magic"
25 # endif
26 #endif

Maybe this requirement is no longer valid. Anyway. I will sent revert
patch and replacement to John.

Thanks,
Arend


\
 
 \ /
  Last update: 2014-03-06 10:21    [W:0.040 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site