lkml.org 
[lkml]   [2014]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 01/12] staging: usbip: userspace: migrate usbip_bind to libudev
From
On Wed, Mar 5, 2014 at 12:15 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Wed, Mar 05, 2014 at 12:42:59PM +0300, Dan Carpenter wrote:
>> On Tue, Mar 04, 2014 at 09:10:41PM +0200, Valentina Manea wrote:
>> > diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.h b/drivers/staging/usbip/userspace/libsrc/usbip_common.h
>> > index 2cb81b3..565ac78 100644
>> > --- a/drivers/staging/usbip/userspace/libsrc/usbip_common.h
>> > +++ b/drivers/staging/usbip/userspace/libsrc/usbip_common.h
>> > @@ -29,6 +29,15 @@
>> > #define USBIP_HOST_DRV_NAME "usbip-host"
>> > #define USBIP_VHCI_DRV_NAME "vhci_hcd"
>> >
>> > +/* sysfs constants */
>> > +#define SYSFS_MNT_PATH "/sys"
>> > +#define SYSFS_BUS_NAME "bus"
>> > +#define SYSFS_BUS_TYPE "usb"
>> > +#define SYSFS_DRIVERS_NAME "drivers"
>>
>> What on earth??? I don't even want to review any further than this.
>>
>> Groan.... No. no no no no no.
>>
>
> I overreacted. This stuff was already in the original code, and this
> change just moves it around.
>
> Fine fine. These patch set seem ok with me.
>
> regards,
> dan carpenter
>
>

Indeed, there are improvements than can be made to the code but
I figured doing them all in just one patch series would be a step too big.
This should be work for future patches.

Thanks for your feedback.

Valentina


\
 
 \ /
  Last update: 2014-03-06 07:41    [W:0.152 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site