lkml.org 
[lkml]   [2014]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 078/131] ipv4: fix counter in_slow_tot
    Date
    3.11.10.6 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Duan Jiong <duanj.fnst@cn.fujitsu.com>

    commit a6254864c08109c66a194612585afc0439005286 upstream.

    since commit 89aef8921bf("ipv4: Delete routing cache."), the counter
    in_slow_tot can't work correctly.

    The counter in_slow_tot increase by one when fib_lookup() return successfully
    in ip_route_input_slow(), but actually the dst struct maybe not be created and
    cached, so we can increase in_slow_tot after the dst struct is created.

    Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    net/ipv4/route.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/net/ipv4/route.c b/net/ipv4/route.c
    index 52e15e8..a8bcc22 100644
    --- a/net/ipv4/route.c
    +++ b/net/ipv4/route.c
    @@ -1598,6 +1598,7 @@ static int __mkroute_input(struct sk_buff *skb,
    rth->rt_gateway = 0;
    rth->rt_uses_gateway = 0;
    INIT_LIST_HEAD(&rth->rt_uncached);
    + RT_CACHE_STAT_INC(in_slow_tot);

    rth->dst.input = ip_forward;
    rth->dst.output = ip_output;
    @@ -1699,8 +1700,6 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr,
    if (err != 0)
    goto no_route;

    - RT_CACHE_STAT_INC(in_slow_tot);
    -
    if (res.type == RTN_BROADCAST)
    goto brd_input;

    @@ -1769,6 +1768,7 @@ local_input:
    rth->rt_gateway = 0;
    rth->rt_uses_gateway = 0;
    INIT_LIST_HEAD(&rth->rt_uncached);
    + RT_CACHE_STAT_INC(in_slow_tot);
    if (res.type == RTN_UNREACHABLE) {
    rth->dst.input= ip_error;
    rth->dst.error= -err;
    --
    1.9.0


    \
     
     \ /
      Last update: 2014-03-09 16:04    [W:4.540 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site