lkml.org 
[lkml]   [2014]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/3] Documentation: mfd: s2mps11: Document support for S2MPS14
    From
    Hi Krzysztof,

    On 5 March 2014 14:52, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
    > Add bindings documentation for S2MPS14 device to the s2mps11 driver.

    nit: s/s2mps11/S2MPS11

    >
    > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
    > Cc: Mark Brown <broonie@kernel.org>
    > Cc: Liam Girdwood <lgirdwood@gmail.com>
    > Cc: Tomasz Figa <t.figa@samsung.com>
    > Cc: devicetree@vger.kernel.org
    > Cc: Rob Herring <robh+dt@kernel.org>
    > Cc: Pawel Moll <pawel.moll@arm.com>
    > Cc: Mark Rutland <mark.rutland@arm.com>
    > Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
    > Cc: Kumar Gala <galak@codeaurora.org>
    > Acked-by: Tomasz Figa <t.figa@samsung.com>
    > ---
    > Documentation/devicetree/bindings/mfd/s2mps11.txt | 12 ++++++++----
    > 1 file changed, 8 insertions(+), 4 deletions(-)
    >
    > diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt
    > index 15ee89c3cc7b..f69bec294f02 100644
    > --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt
    > +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt
    > @@ -1,5 +1,5 @@
    >
    > -* Samsung S2MPS11 Voltage and Current Regulator
    > +* Samsung S2MPS11 and S2MPS14 Voltage and Current Regulator
    >
    > The Samsung S2MPS11 is a multi-function device which includes voltage and
    > current regulators, RTC, charger controller and other sub-blocks. It is
    > @@ -7,7 +7,7 @@ interfaced to the host controller using an I2C interface. Each sub-block is
    > addressed by the host system using different I2C slave addresses.
    >
    > Required properties:
    > -- compatible: Should be "samsung,s2mps11-pmic".
    > +- compatible: Should be "samsung,s2mps11-pmic" or "samsung,s2mps14-pmic".
    > - reg: Specifies the I2C slave address of the pmic block. It should be 0x66.
    >
    > Optional properties:
    > @@ -59,10 +59,14 @@ supports. Note: The 'n' in LDOn and BUCKn represents the LDO or BUCK number
    > as per the datasheet of s2mps11.
    >
    > - LDOn
    > - - valid values for n are 1 to 38
    > + - valid values for n are:
    > + - S2MPS11: 1 to 38
    > + - S2MPS14: 1 to 25
    > - Example: LDO1, LD02, LDO28
    > - BUCKn
    > - - valid values for n are 1 to 10.
    > + - valid values for n are:
    > + - S2MPS11: 1 to 10
    > + - S2MPS14: 1 to 5
    > - Example: BUCK1, BUCK2, BUCK9
    >
    > Example:
    > --
    > 1.7.9.5
    >
    Looks good.
    Acked-by: Sachin Kamat <sachin.kamat@linaro.org>


    --
    With warm regards,
    Sachin


    \
     
     \ /
      Last update: 2014-03-08 12:41    [W:3.033 / U:0.680 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site