lkml.org 
[lkml]   [2014]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 104/131] SELinux: bigendian problems with filename trans rules
    Date
    3.11.10.6 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eric Paris <eparis@redhat.com>

    commit 9085a6422900092886da8c404e1c5340c4ff1cbf upstream.

    When writing policy via /sys/fs/selinux/policy I wrote the type and class
    of filename trans rules in CPU endian instead of little endian. On
    x86_64 this works just fine, but it means that on big endian arch's like
    ppc64 and s390 userspace reads the policy and converts it from
    le32_to_cpu. So the values are all screwed up. Write the values in le
    format like it should have been to start.

    Signed-off-by: Eric Paris <eparis@redhat.com>
    Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
    Signed-off-by: Paul Moore <pmoore@redhat.com>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    security/selinux/ss/policydb.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c
    index 7e5bced..4d35eb7 100644
    --- a/security/selinux/ss/policydb.c
    +++ b/security/selinux/ss/policydb.c
    @@ -3261,10 +3261,10 @@ static int filename_write_helper(void *key, void *data, void *ptr)
    if (rc)
    return rc;

    - buf[0] = ft->stype;
    - buf[1] = ft->ttype;
    - buf[2] = ft->tclass;
    - buf[3] = otype->otype;
    + buf[0] = cpu_to_le32(ft->stype);
    + buf[1] = cpu_to_le32(ft->ttype);
    + buf[2] = cpu_to_le32(ft->tclass);
    + buf[3] = cpu_to_le32(otype->otype);

    rc = put_entry(buf, sizeof(u32), 4, fp);
    if (rc)
    --
    1.9.0


    \
     
     \ /
      Last update: 2014-03-05 17:01    [W:5.213 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site