Messages in this thread | | | Date | Wed, 5 Mar 2014 17:08:41 -0600 | From | Suravee Suthikulanit <> | Subject | Re: [PATCH] iommu/amd: Fix logics to determine and checking max PASID |
| |
On 3/5/2014 4:35 PM, Joerg Roedel wrote: >> - cmd->data[1] = pasid & PASID_MASK; >> >+ cmd->data[1] = pasid & amd_iommu_max_pasid; > ... masking out the other bits is redundant. > > > Joerg
Agree. I can take out the masking stuff here, but I think we should be using the amd_iommu_max_pasid instead of hard coded PASID_MASK for the rest.
Suravee
| |