lkml.org 
[lkml]   [2014]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] selftests: ipc: handle msgget failure return correctly
On 05 Mar 17:51, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A failed msgget causes the test to return an uninitialised value
> in ret. Assign ret to -errno on error exit.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> tools/testing/selftests/ipc/msgque.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/ipc/msgque.c b/tools/testing/selftests/ipc/msgque.c
> index d664182..be8f294 100644
> --- a/tools/testing/selftests/ipc/msgque.c
> +++ b/tools/testing/selftests/ipc/msgque.c
> @@ -202,6 +202,7 @@ int main(int argc, char **argv)
> msgque.msq_id = msgget(msgque.key, IPC_CREAT | IPC_EXCL | 0666);
> if (msgque.msq_id == -1) {
> printf("Can't create queue\n");
> + err = -errno;
> goto err_out;
> }
>
> --

Maybe I am nitpicking here but printf() could modify errno, so you might
as well save it before printf() is called.

--
Guillaume Morin <guillaume@morinfr.org>


\
 
 \ /
  Last update: 2014-03-05 20:21    [W:0.044 / U:0.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site