lkml.org 
[lkml]   [2014]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: Update of file offset on write() etc. is non-atomic with I/O
From
On Tue, Mar 4, 2014 at 12:00 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> OK, with the attached set (the first one is essentially unchanged from
> your first one), it seems to work and produce better code on all targets
> I've tried. Comments?

I'm certainly ok with it. You seem to have left the fput_light()
function around, though, despite removing fget_[raw_]light(). That
seems a bit silly, since there is no valid use any more apart from
net/socket.c that now doesn't balance things properly.

> I've also pushed those (on top of old ocfs2 fix) into vfs.git#for-linus,
> if you prefer to read it that way. Should propagate in a few...

Should I pull?

I also get the feeling that the first patch should likely be marked
for stable. Hmm?

Linus


\
 
 \ /
  Last update: 2014-03-05 00:41    [W:0.079 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site