lkml.org 
[lkml]   [2014]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 62/97] ACPI / PCI: Fix memory leak in acpi_pci_irq_enable()
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Tomasz Nowicki <tomasz.nowicki@linaro.org>

    commit b685f3b1744061aa9ad822548ba9c674de5be7c6 upstream.

    acpi_pci_link_allocate_irq() can return negative gsi even if
    entry != NULL. For that case we have a memory leak, so free
    entry before returning from acpi_pci_irq_enable() for gsi < 0.

    Signed-off-by: Tomasz Nowicki <tomasz.nowicki@linaro.org>
    [rjw: Subject and changelog]
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/acpi/pci_irq.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/acpi/pci_irq.c
    +++ b/drivers/acpi/pci_irq.c
    @@ -432,6 +432,7 @@ int acpi_pci_irq_enable(struct pci_dev *
    pin_name(pin));
    }

    + kfree(entry);
    return 0;
    }




    \
     
     \ /
      Last update: 2014-03-04 22:01    [W:4.116 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site