lkml.org 
[lkml]   [2014]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH RFC 0/6] tty: xuartps renaming
Date
Hi,

this series appears a little messy.
The UART controller in Zynq is Cadence vendor IP. Hence, naming and
identifying this properly would facilitate usage of this driver by other
implementers of this IP. Though, this might sound nice, there are some
details about this series, I am not sure whether they are acceptable:

- the device node name: It currently is 'ttyPS'. I don't know if there
are any rules regarding this and whether this should be changed or
not.
- the UART port #define in include/uapi/linux/serial_core.h is changed
- the series does not cleanly migrate Zynq (which is the only user of
this driver) to the new driver. There is broken UART between the
patches 'tty: Rename xilinx_uart -> cadence_uart' and 'ARM: zynq: DT:
Migrate UART to Cadence binding'. This is mostly due to a change of
the clock names which are used in the DT binding. It might be
possible to make the new and legacy names work, but it would look
rather ugly and since this should affect Zynq only, I hope to get
away with this.

I keep the CC list for the RFC a little reduced, in particular I leave
out the OF people. I think the fundamental questions are in the tty
field and probably ARM. The binding should not be a major problem since
it is essentially used already - it's just missing documentation.

Thanks,
Sören

Soren Brinkmann (6):
tty: xemacps: Clean up
tty: xemacps: Print warning in clock notifier
tty: Rename xilinx_uart -> cadence_uart
tty: cadence: Document DT binding
ARM: zynq: DT: Migrate UART to Cadence binding
ARM: multi_v7_defconfig: Adopt to UART driver renaming

.../devicetree/bindings/serial/cadence_uart.txt | 20 +
arch/arm/boot/dts/zynq-7000.dtsi | 8 +-
arch/arm/configs/multi_v7_defconfig | 4 +-
drivers/tty/serial/Kconfig | 15 +-
drivers/tty/serial/Makefile | 2 +-
drivers/tty/serial/cadence_uart.c | 1457 +++++++++++++++++++
drivers/tty/serial/xilinx_uartps.c | 1524 --------------------
include/uapi/linux/serial_core.h | 4 +-
8 files changed, 1494 insertions(+), 1540 deletions(-)
create mode 100644 Documentation/devicetree/bindings/serial/cadence_uart.txt
create mode 100644 drivers/tty/serial/cadence_uart.c
delete mode 100644 drivers/tty/serial/xilinx_uartps.c

--
1.9.0.1.g4196000

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-03-04 20:01    [W:0.061 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site