Messages in this thread | | | Date | Tue, 4 Mar 2014 11:06:25 +0200 | From | Tomi Valkeinen <> | Subject | Re: [PATCH v5 6/7] of: Implement simplified graph binding for single port devices |
| |
On 27/02/14 19:35, Philipp Zabel wrote: > For simple devices with only one port, it can be made implicit. > The endpoint node can be a direct child of the device node.
<snip>
> @@ -2105,9 +2112,11 @@ struct device_node *of_graph_get_remote_port_parent( > /* Get remote endpoint node. */ > np = of_parse_phandle(node, "remote-endpoint", 0); > > - /* Walk 3 levels up only if there is 'ports' node. */ > + /* Walk 3 levels up only if there is 'ports' node */ > for (depth = 3; depth && np; depth--) { > np = of_get_next_parent(np); > + if (depth == 3 && of_node_cmp(np->name, "port")) > + break; > if (depth == 2 && of_node_cmp(np->name, "ports")) > break; > }
This function becomes a bit funny. Would it be clearer just to do something like:
np = of_parse_phandle(node, "remote-endpoint", 0);
np = of_get_next_parent(np); if (of_node_cmp(np->name, "port") != 0) return np;
np = of_get_next_parent(np); if (of_node_cmp(np->name, "ports") != 0) return np;
np = of_get_next_parent(np); return np;
Tomi
[unhandled content-type:application/pgp-signature] | |