lkml.org 
[lkml]   [2014]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 03/22] axonram: Fix bug in direct_access
On Sun 23-03-14 15:08:29, Matthew Wilcox wrote:
> The 'pfn' returned by axonram was completely bogus, and has been since
> 2008.
Maybe time to drop the driver instead? When noone noticed for 6 years, it
seems pretty much dead... Or is there some possibility the driver can get
reused for new HW?

Anyway the patch looks correct so feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>

Honza

>
> Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
> ---
> arch/powerpc/sysdev/axonram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/sysdev/axonram.c b/arch/powerpc/sysdev/axonram.c
> index 47b6b9f..830edc8 100644
> --- a/arch/powerpc/sysdev/axonram.c
> +++ b/arch/powerpc/sysdev/axonram.c
> @@ -156,7 +156,7 @@ axon_ram_direct_access(struct block_device *device, sector_t sector,
> }
>
> *kaddr = (void *)(bank->ph_addr + offset);
> - *pfn = virt_to_phys(kaddr) >> PAGE_SHIFT;
> + *pfn = virt_to_phys(*kaddr) >> PAGE_SHIFT;
>
> return 0;
> }
> --
> 1.9.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR


\
 
 \ /
  Last update: 2014-03-31 13:21    [W:0.499 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site