lkml.org 
[lkml]   [2014]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] pata_samsung_cf: fix ata_host_activate() failure handling
Date
On Tuesday, April 01, 2014 2:53 AM, Tejun Heo wrote:
>
> Add missing clk_disable() call to ata_host_activate() failure path.
>
> Cc: Ben Dooks <ben-linux@fluff.org>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Reviewed-by: Jingoo Han <jg1.han@samsung.com>

Best regards,
Jingoo Han

> ---
> drivers/ata/pata_samsung_cf.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> Index: b/drivers/ata/pata_samsung_cf.c
> ===================================================================
> --- a/drivers/ata/pata_samsung_cf.c 2014-03-14 16:45:04.344724378 +0100
> +++ b/drivers/ata/pata_samsung_cf.c 2014-03-31 18:31:58.083631437 +0200
> @@ -594,9 +594,13 @@ static int __init pata_s3c_probe(struct
>
> platform_set_drvdata(pdev, host);
>
> - return ata_host_activate(host, info->irq,
> - info->irq ? pata_s3c_irq : NULL,
> - 0, &pata_s3c_sht);
> + ret = ata_host_activate(host, info->irq,
> + info->irq ? pata_s3c_irq : NULL,
> + 0, &pata_s3c_sht);
> + if (ret)
> + goto stop_clk;
> +
> + return 0;
>
> stop_clk:
> clk_disable(info->clk);
>
> --



\
 
 \ /
  Last update: 2014-04-01 04:01    [W:0.062 / U:0.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site