lkml.org 
[lkml]   [2014]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [GIT PULL] x86 LTO changes for v3.15
    > So I think that adding "visible" to asmlinkage is actively wrong and
    > misguided. And the compiler even told you so, but somebody then chose
    > to ignore the compiler telling them that they did stupid things.

    Hi Linus,

    In principle you're right. asmlinkage does not mean visible today.

    However with LTO pretty much all asmlinkages have to become
    visible, as they are used by assembler code and we need to
    tell that to the compiler, otherwise it'll optimize it away.

    So I abused asmlinkage for this.

    The alternative would be to add __visible everywhere we
    have asmlinkage today. I thought it was the lesser evil
    to just add it implicitly.

    If you prefer to do it explicitely I can send
    patches (it would be a very mechanic, long and boring
    tree sweep ...).

    I can send patches for the warnings. Usually the code
    throwing warnings for this has some issue anyways,
    or the asmlinkage is not really needed.

    Please let me know what you prefer.

    -Andi


    \
     
     \ /
      Last update: 2014-04-01 01:41    [W:2.483 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site