Messages in this thread | | | Date | Mon, 31 Mar 2014 15:06:25 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH V2 1/2] checkpatch: Expand parenthesis alignment test to declarations, functions and assignments |
| |
On Mon, 31 Mar 2014 14:58:07 -0700 Joe Perches <joe@perches.com> wrote:
> Currently the parenthesis alignment test works only on > misalignments of if statements like > > if (foo(bar, > baz) > > Expand the test to find misalignments like: > > static inline int foo(int bar, > int baz) > > and > > foo(bar, > baz); > > and > > foo = bar(baz, > qux); > > Expand the $Inline keyword for __inline and __inline__ too. > Add $Inline to $Declare so it also matches "static inline <foo>".
I'm having trouble understanding what this patch actually does. Some little examples would be nice.
I typed in this to play with:
void foo(int a, int b) { }
but I experienced playus interruptus
akpm3:/usr/src/25> perl scripts/checkpatch.pl -f t.c Global symbol "$c90_Keywords" requires explicit package name at scripts/checkpatch.pl line 2162. Execution of scripts/checkpatch.pl aborted due to compilation errors.
System is Ubuntu 12.04.4 (ish).
| |