lkml.org 
[lkml]   [2014]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] mm: convert some level-less printks to pr_*
From
Date
On Mon, 2014-03-31 at 13:35 -0500, Christoph Lameter wrote:
> On Thu, 27 Mar 2014, Mitchel Humpherys wrote:
>
> > diff --git a/mm/slub.c b/mm/slub.c
[]
> > @@ -9,6 +9,8 @@
> > * (C) 2011 Linux Foundation, Christoph Lameter
> > */
> >
> > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> This is implicitly used by some macros? If so then please define this
> elsewhere. I do not see any use in slub.c of this one.

Hi Christoph

All the pr_<level> macros use it.

from include/linux/printk.h:

#ifndef pr_fmt
#define pr_fmt(fmt) fmt
#endif

#define pr_emerg(fmt, ...) \
printk(KERN_EMERG pr_fmt(fmt), ##__VA_ARGS__)

etc...




\
 
 \ /
  Last update: 2014-03-31 22:21    [W:0.107 / U:4.908 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site