lkml.org 
[lkml]   [2014]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [GIT PULL] x86/iommu change for v3.15
From
On Mon, Mar 31, 2014 at 7:49 AM, Ingo Molnar <mingo@kernel.org> wrote:
> Neil Horman (1):
> x86: Adjust irq remapping quirk for older revisions of 5500/5520 chipsets

Before I pull this, I want somebody to double-check it:

> - if (revision == 0x13)
> + if (revision < 0x13)
> set_irq_remapping_broken();

This change does *not* match the comment just above it. The comment
talks very much about revision 13.

So the comment should be fixed, and/or that "< 0x13" should perhaps be
"<= 0x13".

Because making it "less than" simply makes no sense in light of the
comment. Does revision 13 suddenly work? Was that where it was fixed?
If so, please fix the comment.

Linus


\
 
 \ /
  Last update: 2014-03-31 22:21    [W:0.035 / U:1.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site