Messages in this thread | | | Date | Mon, 31 Mar 2014 14:58:26 +0800 | From | "zheng.li" <> | Subject | Re: [PATCH] bonding: Inactive slaves should keep inactive flag's value to 1 |
| |
Hi Jay, What's you think about the new patch.
Thanks, Zheng Li
于 2014年03月28日 17:22, Zheng Li 写道: > In bond mode tlb and alb, inactive slaves should keep inactive flag to 1 to > refuse to receive broadcast packets. Now, active slave send broadcast packets > (for example ARP requests) which will arrive inactive slaves on same host from > switch, but inactive slave's inactive flag is zero that cause bridge receive the > broadcast packets to produce a wrong entry in forward table. Typical situation > is domu send some ARP request which go out from dom0 bond's active slave, then > the ARP broadcast request packets go back to inactive slave from switch, because > the inactive slave's inactive flag is zero, kernel will receive the packets and > pass them to bridge that cause dom0's bridge map domu's MAC address to port of > bond, bridge should map domu's MAC to port of vif. > > Signed-off-by: Zheng Li <zheng.x.li@oracle.com> > --- > drivers/net/bonding/bond_main.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > index e5628fc..f97d72e 100644 > --- a/drivers/net/bonding/bond_main.c > +++ b/drivers/net/bonding/bond_main.c > @@ -3058,7 +3058,7 @@ static int bond_open(struct net_device *bond_dev) > if (bond_has_slaves(bond)) { > read_lock(&bond->curr_slave_lock); > bond_for_each_slave(bond, slave, iter) { > - if ((bond->params.mode == BOND_MODE_ACTIVEBACKUP) > + if ((bond->params.mode == BOND_MODE_ACTIVEBACKUP || bond_is_lb(bond)) > && (slave != bond->curr_active_slave)) { > bond_set_slave_inactive_flags(slave, > BOND_SLAVE_NOTIFY_NOW); >
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |