Messages in this thread | | | Date | Sun, 30 Mar 2014 15:40:57 +0800 | Subject | Re: [PATCH v2 13/29] ktap: add ring buffer handling code(kernel/trace/ktap/kp_transport.[c|h]) | From | Jovi Zhangwei <> |
| |
On Sun, Mar 30, 2014 at 11:58 AM, Andi Kleen <andi@firstfloor.org> wrote: >> >> A lot of code in this file is duplicated with kernel trace_output.c. > > Please modify trace_output instead to avoid this. > Yeah, ktap transport functionality is based on ftrace ring buffer, and reading buffer is through trace pipe.
I will try to figure out some way to reuse ftrace trace pipe reading code as much as possible.
Thanks.
Jovi
| |