Messages in this thread | | | Date | Mon, 3 Mar 2014 11:58:47 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 3/9] drivers: staging: rtl8187se: wrap excessively long lines |
| |
Patch introduces bugs. Please redo and be more careful next time.
On Sat, Mar 01, 2014 at 10:22:47PM -0700, Axel Rasmussen wrote: > Signed-off-by: Axel Rasmussen <axel.rasmussen1@gmail.com> > @@ -935,7 +946,8 @@ static short alloc_rx_desc_ring(struct net_device *dev, u16 bufsize, int count) > tmp = tmp+rx_desc_size; > } > > - *(tmp-rx_desc_size) = *(tmp-rx_desc_size) | (1<<30); /* this is the last descriptor */ > + /* this is the last descriptor */ > + *(tmp - rx_desc_size) = (*tmp-rx_desc_size) | (1 << 30);
You changed "*(tmp-rx_desc_size)" to "(*tmp-rx_desc_size)".
regards, dan carpenter
| |