Messages in this thread | | | Subject | Re: [PATCH 3/7] staging: cxt1e1: Fix line length over 80 characters in linux.c | From | Joe Perches <> | Date | Mon, 03 Mar 2014 19:24:54 -0800 |
| |
On Tue, 2014-03-04 at 11:08 +0900, Daeseok Youn wrote: > clean up checkpatch.pl warnings: > WARNING: Line length over 80 characters
Please run your patches through checkpatch.
> diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt1e1/linux.c
> @@ -431,13 +432,15 @@ create_chan(struct net_device *ndev, ci_t *ci, > priv = OS_kmalloc(sizeof(struct c4_priv)); > if (!priv) > { > - pr_warning("%s: no memory for net_device !\n", ci->devname); > + pr_warning("%s: no memory for net_device !\n", > + ci->devname);
pr_warn would be nice
> @@ -458,10 +461,12 @@ create_chan(struct net_device *ndev, ci_t *ci, > switch (hi->promfmt) > { > case PROM_FORMAT_TYPE1: > - memcpy(dev->dev_addr, (FLD_TYPE1 *) (hi->mfg_info.pft1.Serial), 6); > + memcpy(dev->dev_addr, > + (FLD_TYPE1 *) (hi->mfg_info.pft1.Serial), 6);
Likely better to remove the (FLD_TYPE1 *) altogether.
> break; > case PROM_FORMAT_TYPE2: > - memcpy(dev->dev_addr, (FLD_TYPE2 *) (hi->mfg_info.pft2.Serial), 6); > + memcpy(dev->dev_addr, > + (FLD_TYPE2 *) (hi->mfg_info.pft2.Serial), 6);
Likely better to remove the (FLD_TYPE2 *) too. Maybe consolidate the blocks too.
> @@ -1053,13 +1065,15 @@ c4_add_dev(hdw_info_t *hi, int brdno, unsigned long f0, unsigned long f1, > switch (hi->promfmt) > { > case PROM_FORMAT_TYPE1: > - memcpy(ndev->dev_addr, (FLD_TYPE1 *) (hi->mfg_info.pft1.Serial), 6); > + memcpy(ndev->dev_addr, > + (FLD_TYPE1 *) (hi->mfg_info.pft1.Serial), 6);
unnecessary casts?
> /* unaligned data acquisition */ > memcpy(&tmp, (FLD_TYPE1 *) (hi->mfg_info.pft1.Id), 4);
here too.
> ci->brd_id = cpu_to_be32(tmp); > break; > case PROM_FORMAT_TYPE2: > - memcpy(ndev->dev_addr, (FLD_TYPE2 *) (hi->mfg_info.pft2.Serial), 6); > + memcpy(ndev->dev_addr, > + (FLD_TYPE2 *) (hi->mfg_info.pft2.Serial), 6); > /* unaligned data acquisition */ > memcpy(&tmp, (FLD_TYPE2 *) (hi->mfg_info.pft2.Id), 4);
etc.
| |