Messages in this thread Patch in this message | | | From | Namhyung Kim <> | Subject | [PATCH 03/10] perf tools: Use hpp formats to sort hist entries | Date | Tue, 4 Mar 2014 11:42:09 +0900 |
| |
It wrapped sort entries to hpp functions, so using the hpp sort list to sort entries.
Signed-off-by: Namhyung Kim <namhyung@kernel.org> --- tools/perf/util/hist.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c index dacd1e06c94b..0d8f2ec6f94d 100644 --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c @@ -437,11 +437,11 @@ struct hist_entry *__hists__add_entry(struct hists *hists, int64_t hist_entry__cmp(struct hist_entry *left, struct hist_entry *right) { - struct sort_entry *se; + struct perf_hpp_fmt *fmt; int64_t cmp = 0; - list_for_each_entry(se, &hist_entry__sort_list, list) { - cmp = se->se_cmp(left, right); + perf_hpp__for_each_sort_list(fmt) { + cmp = fmt->cmp(left, right); if (cmp) break; } @@ -452,15 +452,11 @@ hist_entry__cmp(struct hist_entry *left, struct hist_entry *right) int64_t hist_entry__collapse(struct hist_entry *left, struct hist_entry *right) { - struct sort_entry *se; + struct perf_hpp_fmt *fmt; int64_t cmp = 0; - list_for_each_entry(se, &hist_entry__sort_list, list) { - int64_t (*f)(struct hist_entry *, struct hist_entry *); - - f = se->se_collapse ?: se->se_cmp; - - cmp = f(left, right); + perf_hpp__for_each_sort_list(fmt) { + cmp = fmt->collapse(left, right); if (cmp) break; } -- 1.7.11.7
| |