lkml.org 
[lkml]   [2014]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] x86, kmemcheck: Use kstrtoint() instead of sscanf()
On 02/20/2014 12:14 AM, David Rientjes wrote:
> Kmemcheck should use the preferred interface for parsing command line
> arguments, kstrto*(), rather than sscanf() itself. Use it appropriately.
>
> Signed-off-by: David Rientjes <rientjes@google.com>

Acked-by: Pekka Enberg <penberg@kernel.org>

Andrew, can you pick this up?

> ---
> arch/x86/mm/kmemcheck/kmemcheck.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/mm/kmemcheck/kmemcheck.c b/arch/x86/mm/kmemcheck/kmemcheck.c
> --- a/arch/x86/mm/kmemcheck/kmemcheck.c
> +++ b/arch/x86/mm/kmemcheck/kmemcheck.c
> @@ -78,10 +78,16 @@ early_initcall(kmemcheck_init);
> */
> static int __init param_kmemcheck(char *str)
> {
> + int val;
> + int ret;
> +
> if (!str)
> return -EINVAL;
>
> - sscanf(str, "%d", &kmemcheck_enabled);
> + ret = kstrtoint(str, 0, &val);
> + if (ret)
> + return ret;
> + kmemcheck_enabled = val;
> return 0;
> }
>



\
 
 \ /
  Last update: 2014-03-03 14:41    [W:2.326 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site