Messages in this thread | | | Date | Mon, 3 Mar 2014 11:42:22 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 3/4] power_supply: Introduce PSE compliant algorithm |
| |
Hi!
> > > Just to convey that is_battery_full is a local function and not generic. You > > > can find similar usage in power_supply_core.c (__power_supply_changed_work) > > > and in other drivers. Isn't it advised to have __ prefixes? > > > > It is static; everybody sees it is local. __ prefix usually means > > something else. > > Agreed, I will remove the __ prefix in next patchset. Meanwhile I would > appreciate if anyone could help me to understand what __ prefix > really means.
If you have __foo() and foo(), the __foo() is typically worker function, where foo() provides locking around it etc. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |