[lkml]   [2014]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [media] videobuf-dma-contig: fix vm_iomap_memory() call
On 03/27/2014 12:07 PM, Ma Haijun wrote:
> Hi all,
> This is a trivial fix, but I think the patch itself has problem too.
> The function requires a phys_addr_t, but we feed it with a dma_handle_t.
> AFAIK, this implicit conversion does not always work.
> Can I use virt_to_phys(mem->vaddr) to get the physical address instead?
> (mem->vaddr and mem->dma_handle are from dma_alloc_coherent)

Does this actually fail? With what driver and on what hardware?

I ask because I am very reluctant to make any changes to videobuf. It is
slowly being replaced by the vastly superior videobuf2 framework. Existing
drivers in the kernel still using the old videobuf seem to work just fine
(or at least as fine as videobuf allows you to be).



> Regards
> Ma Haijun
> Ma Haijun (1):
> [media] videobuf-dma-contig: fix incorrect argument to
> vm_iomap_memory() call
> drivers/media/v4l2-core/videobuf-dma-contig.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

 \ /
  Last update: 2014-03-28 11:21    [W:0.060 / U:2.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site