lkml.org 
[lkml]   [2014]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] openvswitch: supply a dummy err_handler of gre_cisco_protocol to prevent kernel crash
On Thu, Mar 27, 2014 at 2:56 PM, Wei Zhang <asuka.com@163.com> wrote:
> diff --git a/net/openvswitch/vport-gre.c b/net/openvswitch/vport-gre.c
> index a3d6951..d64c639 100644
> --- a/net/openvswitch/vport-gre.c
> +++ b/net/openvswitch/vport-gre.c
> @@ -110,6 +110,12 @@ static int gre_rcv(struct sk_buff *skb,
> return PACKET_RCVD;
> }
>
> +static int gre_dummy_err(struct sk_buff *skb, u32 info,
> + const struct tnl_ptk_info *tpi)
> +{
> + return PACKET_REJECT;
> +}

I'm not sure that rejecting all ICMP packets is the correct thing do
here since it means that we could pass them onto a later caller even
though they are intended for us. We should probably use the same logic
as for receiving packets and just discard them here.


\
 
 \ /
  Last update: 2014-03-28 23:21    [W:0.041 / U:5.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site