lkml.org 
[lkml]   [2014]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 1/3] mfd: Add realtek USB card reader driver
[...]

> >>+static int rtsx_usb_suspend(struct usb_interface *intf, pm_message_t message)
> >>+{
> >>+ struct rtsx_ucr *ucr =
> >>+ (struct rtsx_ucr *)usb_get_intfdata(intf);
> >>+
> >>+ dev_dbg(&intf->dev, "%s called with pm message 0x%04u\n",
> >>+ __func__, message.event);
> >>+
> >>+ mutex_lock(&ucr->dev_mutex);
> >>+ rtsx_usb_turn_off_led(ucr);
> >
> >When is this turned on again?
> >
>
> The LED is not in a permanent cut-off state after here. It is called
> to guarantee the LED is off during suspend to save more power. It
> could be lit up in the card host drivers(e.g. rtsx_usb_sdmmc.c)
> anytime whenever necessary.
>
> This has been asked may times. I'm considering putting some comment
> in next revision.

Yes, please do.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-03-28 09:21    [W:0.062 / U:3.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site