lkml.org 
[lkml]   [2014]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCHv2 net] vhost: fix total length when packets are too short
From
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Thu, 27 Mar 2014 12:00:26 +0200

> When mergeable buffers are disabled, and the
> incoming packet is too large for the rx buffer,
> get_rx_bufs returns success.
>
> This was intentional in order for make recvmsg
> truncate the packet and then handle_rx would
> detect err != sock_len and drop it.
>
> Unfortunately we pass the original sock_len to
> recvmsg - which means we use parts of iov not fully
> validated.
>
> Fix this up by detecting this overrun and doing packet drop
> immediately.
>
> CVE-2014-0077
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> Changes from v1:
> Fix CVE# in the commit log.
> Patch is unchanged.
>
> Note: this is needed for -stable.

Applied and queued up for -stable.

> I wonder if this can still make the release.

I will try but no promises.


\
 
 \ /
  Last update: 2014-03-28 21:21    [W:0.053 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site