[lkml]   [2014]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH v6 00/11] CPU idle for Armada XP
This patch set adds the CPU idle support for Armada XP and prepares
the support for Armada 370. This was based on the work of Nadav

The main change in this new version is a rebasing onto the PMSU
reworked series sent by Thomas Petazzoni:

I also took into account the comments I received, see the changelog
for the details.

The first patch should go through ARM subsystem and should be taken by
Russell King. There was no change since the last version, so I am
submitting it to Russell's patch system.

All the other patches can go to mvebu subsystem (and then arm-soc)
even the patch 10, if the PM maintainers agree, of course in this case
we need an acked-by from them.

I would like also to have a acked-by (or at least a reviewed-by) from
the PM maintainers for the patches 8 and 9.

The whole series (and the pmsu patches needed) is also available in
the branch CPU-idle-ArmadaXP-v6 at



v5 -> v6:

* rebased onto the pmsu reworked patch set

* fixed the wrong indent for ARM_BE8 in coherency_ll.S

* Improved the tests done in armada_370_xp_cpu_pm_init as suggested
by Thomas Petazzoni. Each condition is tested separately then it
will be more readable.

v4 -> v5:

* Call v7 version of suspend and resume from the pj4b callback instead
of copying the code, following Lorenzo advice.

* Split the low level functions to manipulate HW coherency

* Reorder the included headers in cpuidle-armada-370-xp.c

* Added comment in the inline asm part of armada_370_xp_cpu_suspend
function where the CR_C is restored.

* Added comment about the fact that Armada XP can us ldrex/strex
without MMU enabled

* Fixed commit logs

* Added the acked-by from Thomas Petazzoni

* Extend the pmsu registers instead of adding a new set of register

* Move the pm initialization outside of the board file in a

* Move most of the architecture specific code in arch/arm/mach-mvebu
and use platform device data file to pass the callback as suggested
by Daniel.

* Added the tlb flush if the wfi failed.

* Check the cpu_suspend return value

* rebased on mvebu/for-next to be in sync all the change made in mach-mvebu

v3 -> v4:

* factorized the code in coherency_ll.S and make it autodetect as mush
as possible

* reordered the introduction of the device tree binding

* removed all the EXPORT_SYMBOL_GPL as the driver can only be built
into the kernel and never be built as a module.

* moved the armada_370_xp_pmsu_enable_l2_powerdown_onidle function in
armada_370_cp.c file during the initialization of the platform.

* fixed various coding style issue and typos pointed by Thomas

* fixed all the coding issue style, made the comments more coherent
and add more comment in the suspend-armada-370-xp.S file.

* moved all the device tree related check from
armada_370_xp_cpuidle_probe to armada_370_xp_dt_init.

* used cpu_pm_enter() instead of directly calling platform code in

* convert the sequence to disable the coherency to the one used in

* Rebased on v3.14-rc1

v2 -> v3:

* Converted the driver to use module_platform_driver. This lead to the
introduction of a new patch (PATCH 11). Pointed by Daniel Lezcano.

* Used PUIDLE_DRIVER_FLAGS_MASK to store the deep idle information,
suggested by Daniel Lezcano.

* Removed cpu_init call from armada_370_xp_enter_idle
function. Pointed by Lorenzo Pieralisi.

* Rebased on v3.12-rc5

v1 -> v2:

* Removed the pm_level kernel parameter. As Kevin Hilman pointed, its
usage can be replaced by using
/sys/devices/system/cpu/cpu*/cpuidle/state*/disable or the kernel

* Used BIT() macro (reported by Ezequiel)

* Made the function more readable the
armada_370_xp_pmsu_idle_prepare() function (reported by Thomas)

* Moved the config entry in Kconfig.arm, and rename the config symbol
according the pattern used by other arm cpu: ARM_"soc name"_CPUIDLE

* Moved the build rule under the new ARM SoC section in the Makefile

* Rebased on Linus Torvalds master branch of Thursday September 12

Gregory CLEMENT (11):
ARM: PJ4B: Add cpu_suspend/cpu_resume hooks for PJ4B
ARM: mvebu: remove the address parameter for ll_set_cpu_coherent
ARM: mvebu: ll_set_cpu_coherent always uses the current CPU
ARM: mvebu: Remove the unused argument of set_cpu_coherent()
ARM: mvebu: Split low level functions to manipulate HW coherency
ARM: mvebu: Low level function to disable HW coherency support
ARM: mvebu: Allow to power down L2 cache controller in idle mode
ARM: mvebu: Add the PMSU related part of the cpu idle functions
ARM: mvebu: Register notifier callback for the cpuidle transition
cpuidle: mvebu: Add initial CPU idle support for Armada 370/XP SoC
ARM: mvebu: register the cpuidle driver for the Armada XP SoCs

arch/arm/mach-mvebu/coherency.c | 16 +--
arch/arm/mach-mvebu/coherency.h | 2 +-
arch/arm/mach-mvebu/coherency_ll.S | 122 +++++++++++++++----
arch/arm/mach-mvebu/headsmp.S | 15 +--
arch/arm/mach-mvebu/platsmp.c | 2 +-
arch/arm/mach-mvebu/pmsu.c | 207 +++++++++++++++++++++++++++++++-
arch/arm/mm/proc-v7.S | 28 ++++-
drivers/cpuidle/Kconfig.arm | 5 +
drivers/cpuidle/Makefile | 1 +
drivers/cpuidle/cpuidle-armada-370-xp.c | 93 ++++++++++++++
10 files changed, 438 insertions(+), 53 deletions(-)
create mode 100644 drivers/cpuidle/cpuidle-armada-370-xp.c


 \ /
  Last update: 2014-03-28 12:41    [W:0.106 / U:11.928 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site