lkml.org 
[lkml]   [2014]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/4] kmemleak: allow freeing internal objects after kmemleak was disabled
>> +	if (!kmemleak_has_leaks)
>> + __kmemleak_do_cleanup();
>> + else
>> + pr_info("Disable kmemleak without freeing internal objects, "
>> + "so you may still check information on memory leaks. "
>> + "You may reclaim memory by writing \"clear\" to "
>> + "/sys/kernel/debug/kmemleak\n");
>
> Alternative text:
>
> pr_info("Kmemleak disabled without freeing internal data. "
> "Reclaim the memory with \"echo clear > /sys/kernel/debug/kmemleak\"\n");
>
> (I'm wouldn't bother with long lines in printk strings)
>
> Otherwise:
>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
>

Thanks for the review!



\
 
 \ /
  Last update: 2014-03-28 12:01    [W:0.038 / U:4.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site