Messages in this thread | | | Date | Thu, 27 Mar 2014 14:34:08 -0700 | Subject | Re: git pull -- [PATCH] aio: v2 ensure access to ctx->ring_pages is correctly serialised | From | Linus Torvalds <> |
| |
On Thu, Mar 27, 2014 at 1:57 PM, Benjamin LaHaise <bcrl@kvack.org> wrote: > > *nod* -- I added that to the below variant.
You still have "goto err" for cases that have the ctx locked. Which means that the thing gets free'd while still locked, which causes problems for lockdep etc, so don't do it.
Do what I did: add a "err_unlock" label, and make anybody after the mutex_lock() call it. No broken shortcuts.
Linus
| |