Messages in this thread | | | Date | Thu, 27 Mar 2014 10:48:54 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH] workqueue: add __WQ_FREEZING and remove POOL_FREEZING |
| |
On Thu, Mar 27, 2014 at 08:08:39PM +0800, Lai Jiangshan wrote: > On 03/25/2014 05:56 PM, Lai Jiangshan wrote: > > freezing is nothing related to pools, but POOL_FREEZING adds a connection, > > and causes freeze_workqueues_begin() and thaw_workqueues() complicated. > > > > Since freezing is workqueue instance attribute, so we introduce __WQ_FREEZING > > to wq->flags instead and remove POOL_FREEZING. > > > > we set __WQ_FREEZING only when freezable(to simplify pwq_adjust_max_active()), > > make freeze_workqueues_begin() and thaw_workqueues() fast skip non-freezable wq. > > > > Changed from previous patches(requested by tj): > > 1) added the WARN_ON_ONCE() back > > 2) merged the two patches as one > > Ping. > > Hi, Tejun > > You had reviewed this patch several rounds. > I had applied all your requests(the last two is listed above) in your comments. > > I'm deeply sorry for responding so late.
No worries but I think it's a bit too late in the devel cycle to apply it to for-3.15. Let's do it in the next cycle. Can you please ping me when v3.16-rc1 drops?
Thanks.
-- tejun
| |