[lkml]   [2014]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] ARM: machine_power_off should not return

Thanks for the reply!

On Mar 26, Russell King - ARM Linux wrote:
> On Tue, Mar 25, 2014 at 07:45:55PM -0300, Ezequiel Garcia wrote:
> >
> > Without this patch we got the heartbeat's reboot_notifier called twice while
> > testing the recent hibernation patches, which was unexpected and produced a
> > kernel panic:
> I don't see why we should make this change. kernel/reboot.c handles
> this function returning, so other places should do too.
> Even on x86, this function can return:
> Therefore, I'd say... it's a bug in the hibernation code - or we probably
> have many buggy architectures. I'd suggest fixing the hibernation code
> rather than stuffing some workaround like an endless loop into every
> architecture.

Which is exactly what Sebastian did first:

But Pavel asked to fix ARM's machine_power_off instead.

Also, looking at the other architectures, it seems this API is not well
defined: some of them have an infinite loop, some don't. So it's hard to
say the function is supposed to return or not.
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2014-03-26 12:01    [W:0.058 / U:19.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site