| From | Kamal Mostafa <> | Subject | [PATCH 3.8 65/81] PM / hibernate: Fix restore hang in freeze_processes() | Date | Tue, 25 Mar 2014 10:16:18 -0700 |
| |
3.8.13.20 -stable review patch. If anyone has any objections, please let me know.
------------------
From: Sebastian Capella <sebastian.capella@linaro.org>
commit f8d5b9e9e5372f0deb7bc1ab1088a9b60b0a793d upstream.
During restore, pm_notifier chain are called with PM_RESTORE_PREPARE. The firmware_class driver handler fw_pm_notify does not have a handler for this. As a result, it keeps a reader on the kmod.c umhelper_sem. During freeze_processes, the call to __usermodehelper_disable tries to take a write lock on this semaphore and hangs waiting.
Signed-off-by: Sebastian Capella <sebastian.capella@linaro.org> Acked-by: Ming Lei <ming.lei@canonical.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Kamal Mostafa <kamal@canonical.com> --- drivers/base/firmware_class.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index b392b35..abb2054 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -1413,6 +1413,7 @@ static int fw_pm_notify(struct notifier_block *notify_block, switch (mode) { case PM_HIBERNATION_PREPARE: case PM_SUSPEND_PREPARE: + case PM_RESTORE_PREPARE: device_cache_fw_images(); break; -- 1.8.3.2
|