Messages in this thread | | | Date | Tue, 25 Mar 2014 14:58:02 +0000 | From | Lee Jones <> | Subject | Re: [RFC 01/47] mtd: nand: export useful functions from core driver |
| |
On Tue, 25 Mar 2014, Ezequiel Garcia wrote:
> On Mar 25, Lee Jones wrote: > > These functions are utilised by the STM BCH NAND Controller driver. > > > [..] > > -static int nand_suspend(struct mtd_info *mtd) > > +int nand_suspend(struct mtd_info *mtd) > > { > > return nand_get_device(mtd, FL_PM_SUSPENDED); > > } > > +EXPORT_SYMBOL(nand_suspend); > > > > /** > > * nand_resume - [MTD Interface] Resume the NAND flash > > * @mtd: MTD device structure > > */ > > -static void nand_resume(struct mtd_info *mtd) > > +void nand_resume(struct mtd_info *mtd) > > { > > struct nand_chip *chip = mtd->priv; > > > > @@ -2776,6 +2779,7 @@ static void nand_resume(struct mtd_info *mtd) > > pr_err("%s called for a chip which is not in suspended state\n", > > __func__); > > } > > +EXPORT_SYMBOL(nand_resume); > > > > The patch that adds the PM support for the driver makes no use of these. > > Can you detail why do you need to export these?
Please see RFC PATCH 9:
mtd: nand: stm_nand_bch: introduce and initialise some important data structures
static void nandi_set_mtd_defaults(struct nandi_controller *nandi, struct mtd_info *mtd, struct nand_chip *chip) {
[...] mtd->_sync = nand_sync; mtd->_suspend = nand_suspend; mtd->_resume = nand_resume; }
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |