| Date | Tue, 25 Mar 2014 00:02:06 +0100 | From | Thierry Reding <> | Subject | Re: [PATCH 09/12] drm/nouveau/graph: pad firmware code at load time |
| |
On Mon, Mar 24, 2014 at 05:42:31PM +0900, Alexandre Courbot wrote: > Pad the microcode to a multiple of 0x40, otherwise firmware will fail to > run from non-prepadded firmware files.
Perhaps this (and the comment in the code) should mention a unit. In this case it's 0x40 words. Also, I think using a decimal number would read easier here and in the comment. Furthermore, perhaps choosing a byte as the unit would be even more intuitive.
But either way the code is correct, so:
Reviewed-by: Thierry Reding <treding@nvidia.com> [unhandled content-type:application/pgp-signature] |