Messages in this thread | | | Subject | Re: [PATCH] staging: line6: Fix missing blanks after declarations | From | Joe Perches <> | Date | Mon, 24 Mar 2014 14:35:13 -0700 |
| |
On Mon, 2014-03-24 at 21:51 +0100, Fabian Mewes wrote: > This patch is part of eudyptula challenge task 10 > > Signed-off-by: Fabian Mewes <architekt@coding4coffee.org>
Hi Fabian.
The patch seems fine, but please do not use something like the above as a commit message.
It would be better to describe _why_ the change should be done. Something like:
------
Subject: [PATCH] staging: line6: Add blank lines after declarations
Use the more common kernel coding style.
Signed-off-by: your name <your.email@domain.tld>
| |