lkml.org 
[lkml]   [2014]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: line6: Fix missing blanks after declarations
From
Date
On Mon, 2014-03-24 at 21:51 +0100, Fabian Mewes wrote:
> This patch is part of eudyptula challenge task 10
>
> Signed-off-by: Fabian Mewes <architekt@coding4coffee.org>

Hi Fabian.

The patch seems fine, but please do not use something
like the above as a commit message.

It would be better to describe _why_ the change should
be done. Something like:

------

Subject: [PATCH] staging: line6: Add blank lines after declarations

Use the more common kernel coding style.

Signed-off-by: your name <your.email@domain.tld>



\
 
 \ /
  Last update: 2014-03-24 23:01    [W:0.040 / U:0.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site