lkml.org 
[lkml]   [2014]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2] iommu/amd: Fix logic to determine and checking max PASID
Date
Joerg Roedel wrote:

>On Wed, Mar 05, 2014 at 06:54:18PM -0600, suravee.suthikulpanit@amd.com wrote:
>> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>>
>> In reality, the spec can only support 16-bit PASID since
>> INVALIDATE_IOTLB_PAGES and COMPLETE_PPR_REQUEST commands only allow
>> 16-bit PASID. So, we updated the PASID_MASK accordingly and invoke
>>BUG_ON if the hardware is reporting PASmax more than 16-bit.
>>
>>Besides, max PASID is defined as ((2^(PASmax+1)) - 1). The current
>> does not determine this correctly.
>>
>> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>> Tested-by: Jay Cornwall <Jay.Cornwall@amd.com>
>
> Applied, thanks.
>
> Btw, is there any publicly available driver/way/whatever for me to test the AMD IOMMUv2 code paths?

We are testing on a kernel development branch which enables ATS translation from shaders on the Kaveri APU. See drivers/gpu/hsa/radeon at http://cgit.freedesktop.org/~gabbayo/linux/ for the kernel driver.

Testing requires some setup in user mode to construct a PM4 command stream and CIK assembly, similar to the DRM/Mesa UMD implementation. Even then, it is not possible to observe translations directly. Our testing is limited to indirect observations; e.g. modifying VA:PA mappings and ensuring shader loads/stores reflect expected results.

I don't know of a way to exercise the IOMMUv2 code paths without an IOTLB client.



\
 
 \ /
  Last update: 2014-03-24 21:01    [W:0.063 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site