Messages in this thread | | | Subject | Re: [PATCH v2] NVMe: silence GCC warning on 32 bit | From | Paul Bolle <> | Date | Mon, 24 Mar 2014 16:57:46 +0100 |
| |
On Mon, 2014-03-24 at 16:49 +0100, Geert Uytterhoeven wrote: > On Mon, Mar 24, 2014 at 4:36 PM, Paul Bolle <pebolle@tiscali.nl> wrote: > > And as this is now unlikely to be in time for v3.14, we might decide to > > dig deeper. It won't be the first time that a rather small change (say, > > converting a variable from signed to unsigned) turns out be enough to > > make GCC understand the flow of the code. > > Anything we can do with factoring out the "if (!first)" in both branches?
That was basically my approach in version one: drop "first" all together. Worked great: the warning was gone. But Keith noted that I also completely broke the logic of the code. So I decided, after some further attempts, to take the easy way out and and initialize "bvprv" to { NULL }.
Paul Bolle
| |