lkml.org 
[lkml]   [2014]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [patch 15/16] cpufreq: intel-pstate: Use del_timer_sync in intel_pstate_cpu_exit()
    From
    On Sun, Mar 23, 2014 at 8:39 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
    > We are about to free the data structure. Make sure no timer callback
    > is running. I might be paranoid, but the ->exit callback can be
    > invoked from so many places, that it is not entirely clear whether
    > del_timer is always called on the cpu on which it is enqueued.

    In normal cases it will be called only when CPU goes offline and I
    hope that isn't called on the dying CPU.

    > While looking through the call sites I noticed, that
    > cpufreq_init_policy() can fail and invoke cpufreq_driver->exit() but
    > it does not return the failure and the callsite happily proceeds.

    Thanks for reporting this, will get it fixed.

    > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
    > Cc: cpufreq <cpufreq@vger.kernel.org>
    > Cc: pm <linux-pm@vger.kernel.org>
    > ---
    >
    > drivers/cpufreq/intel_pstate.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > Index: tip/drivers/cpufreq/intel_pstate.c
    > ===================================================================
    > --- tip.orig/drivers/cpufreq/intel_pstate.c
    > +++ tip/drivers/cpufreq/intel_pstate.c
    > @@ -777,7 +777,7 @@ static int intel_pstate_cpu_exit(struct
    > {
    > int cpu = policy->cpu;
    >
    > - del_timer(&all_cpu_data[cpu]->timer);
    > + del_timer_sync(&all_cpu_data[cpu]->timer);

    Acked-by: Viresh Kumar <viresh.kumar@linaro.org>


    \
     
     \ /
      Last update: 2014-03-24 06:21    [W:2.157 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site