Messages in this thread Patch in this message | | | Date | Sun, 23 Mar 2014 11:13:10 -0700 | From | Josh Triplett <> | Subject | Re: [patch 06/16] rcu: torture: Add missing destroy_timer_on_stack() |
| |
On Sun, Mar 23, 2014 at 03:09:27PM -0000, Thomas Gleixner wrote: > Otherwise we leak a tracking object if DEBUG_OBJECTS is enabled. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Cc: Josh Triplett <josh@freedesktop.org> > Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> kernel/rcu/torture.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > Index: tip/kernel/rcu/torture.c > =================================================================== > --- tip.orig/kernel/rcu/torture.c > +++ tip/kernel/rcu/torture.c > @@ -1038,8 +1038,10 @@ rcu_torture_reader(void *arg) > } while (!kthread_should_stop() && fullstop == FULLSTOP_DONTSTOP); > VERBOSE_PRINTK_STRING("rcu_torture_reader task stopping"); > rcutorture_shutdown_absorb("rcu_torture_reader"); > - if (irqreader && cur_ops->irq_capable) > + if (irqreader && cur_ops->irq_capable) { > del_timer_sync(&t); > + destroy_timer_on_stack(&t); > + } > while (!kthread_should_stop()) > schedule_timeout_uninterruptible(1); > return 0; > >
| |